Converge ISO Node pins on normal updates - #10878
Open
Drecullith wants to merge 1 commit into
Open
Drecullith wants to merge 1 commit into
Drecullith wants to merge 1 commit into
Conversation
Drecullith
force-pushed
the
fix/iso-node-mise-latest
branch
from
September 15, 2026 16:07
dbce7a9 to
93894d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate legacy offline-ISO Node pins onto Omarchy's normal
latestmise policy during a regular update.Older offline ISO provisioning wrote the bundled Node version into the user's global mise config as an exact pin so setup could complete without network access. Those already-installed machines remain frozen on that exact version because
omarchy updaterunsmise up, which respects the configured range.Upstream #11656 now prevents new offline installs from retaining the exact pin: after registering the bundled Node version, provisioning rewrites the configured policy to
latest.This PR complements that fix by handling the existing installed base.
mise-work.shdoes not run again on machines that were already provisioned, so those legacy exact pins otherwise remain unchanged.During the first normal mise update, this change:
node@latest;MISE_MINIMUM_RELEASE_AGE=0 mise up;Machines without retained ISO provisioning packages are unaffected.
An exact Node pin that does not match the retained bundled ISO version is also preserved.
Together, #11656 and this PR cover both sides of the lifecycle:
omarchy update.Fixes #10820.
Why this still matters after #11656
#11656 changes the provisioning path only. It does not revisit user configuration already written on installed systems.
Issue #10820 has a confirmed example of an existing ISO-installed machine whose retained provisioning tarball still matches its exact Node pin. On that class of machine, this migration path would identify the pin as Omarchy-owned and safely retarget it without treating unrelated user pins as migration candidates.
Tests
Added
test/shell.d/update-mise-test.shcovering:latest;mise upstill runs afterwards;The focused regression suite passes locally.
Also verified:
bash -n bin/omarchy-update-misebash -n test/shell.d/update-mise-test.sh